Adjust no_auth test expectation to address semver hazards failure
#4211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
landonxjames
approved these changes
Jul 15, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
added a commit
that referenced
this pull request
Jul 17, 2025
~**semver-hazards check failure will be resolved when #4211 is released from `aws-sdk-rust`**~ ## Description Add support for auth scheme preference, which allows customers to re-prioritize the order of auth schemes originally determined by the auth scheme resolver. See [the changelog](https://github.com/smithy-lang/smithy-rs/blob/2d483a0880c30683858329fc8411e9f9282de633/.changelog/1752160009.md) where the auth scheme preference can be configured. Note: The preference list is merely a hint rather than a strict override. Any auth schemes not included in the originally resolved auth schemes will be ignored, and won't be an error. ~To support the implementation, a utility method has been added to `NowOrLater` to map an inner future.~ ## Testing Those called out in the feature spec: - [auth_scheme_preference_should_take_the_highest_priority](https://github.com/smithy-lang/smithy-rs/pull/4203/files#diff-b45485e1d1dd937e149c9c703156aa1a7f71b2bbbd5dddb29ffba385b65c50b0R12) for `Alternative Auth Resolution` - [test_resolve_identity](https://github.com/smithy-lang/smithy-rs/pull/4203/files#diff-db7260e3be202c63463123101814c7bf23ef47796bf23a14d67f567285039d46R891) to verify `Resolving Auth and Credentials` - [auth scheme preference](https://github.com/smithy-lang/smithy-rs/pull/4203/files#diff-e63831c17293fd55b608a406f472155f8809239f3c3afba20bcd77bdc8da2ea3R140) to verify `Manual auth schemes configuration` - [test for parsing auth scheme preference from environmental configuration](https://github.com/smithy-lang/smithy-rs/pull/4203/files#diff-d9b0e8d5e74b3e0542908745494b34c1784153ed4e566fe1ce581f8605e801eaR99) ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "client," "server," or both in the `applies_to` key. - [x] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "aws-sdk-rust" in the `applies_to` key. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR is a prerequisite for #4203.
Details
PR4203 has updated some of the
AuthSchemeIdstring values, which causes theno_authtest to fail in the semver hazards check. This happens because the inner string value forNO_AUTH_SCHEME_IDhas been modified fromno_authtonoAuth.To resolve this, this PR updates the test expectation so that it no longer depends on raw string values. Once this PR is merged and released from
aws-sdk-rust, PR4203 should pass the semver hazards check successfully.Also the test has been moved to
no_auth.rssince it is not specific to S3 Express; it was originally placed inexpress.rsbecause the issue was first discovered while investigating S3 Express behavior.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.